add kv to terraform sample of aci sample app#70
Merged
Conversation
paolosalvatori
approved these changes
Apr 2, 2026
Contributor
paolosalvatori
left a comment
paolosalvatori
left a comment
There was a problem hiding this comment.
Thanks @DrisDary, nice job. Just a minor suggestion, see below. Thanks for fixing also the deploy.sh script of the function-app-storage-http sample.
DrisDary
force-pushed
the
aci-terraform-kv-addition
branch
from
a349ba5 to
4d09ec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Terraform deployment for the aci-blob-storage sample was missing Key Vault integration. The Bicep and az CLI script deployments both use Azure Key Vault to store the storage connection string as a secret before passing it to ACI, but the Terraform version hardcoded the connection string directly as a secure environment variable. Now that the LocalStack Azure emulator supports Key Vault in Terraform, we can bring the Terraform deployment in line with the other two.
Additionally, the funclocal CLI wrapper was removed upstream (see localstack-docs#532) because azlocal start-interception already routes func traffic to LocalStack, making funclocal redundant. References to funclocal in run-samples.sh and the function-app deploy scripts were blocking CI for all shards.